<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103140/">http://git.reviewboard.kde.org/r/103140/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Aleix Pol Gonzalez.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch shows the additions and changes in the KDevelop C++ support to provide the data structures used for increased verbosity on the code.
See: https://git.reviewboard.kde.org/r/103071/
In this patch I guess the most controversial part is the ParseSession::typeFromCallAst addition. I think it's useful to have, but probably we can sort it out in some other way by querying the DUChain. I'd prefer to know what do you guys think.
Thanks!
PS: In this patch I'd appreciate if you concentrate on the actual changes being done instead of the style. ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See the unit tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/cppduchain/CMakeLists.txt <span style="color: grey">(5f27b8f)</span></li>
<li>languages/cpp/cppduchain/controlflowgraphbuilder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/cppduchain/controlflowgraphbuilder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/cppduchain/expressionvisitor.h <span style="color: grey">(d62495d)</span></li>
<li>languages/cpp/cppduchain/expressionvisitor.cpp <span style="color: grey">(9379285)</span></li>
<li>languages/cpp/cppduchain/name_visitor.cpp <span style="color: grey">(d15769e)</span></li>
<li>languages/cpp/cppduchain/tests/CMakeLists.txt <span style="color: grey">(363404f)</span></li>
<li>languages/cpp/cppduchain/tests/codeanalysistest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/cppduchain/tests/codeanalysistest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/cppduchain/tests/test_duchain.h <span style="color: grey">(d4b0edf)</span></li>
<li>languages/cpp/cppduchain/tests/testhelper.h <span style="color: grey">(61a3de2)</span></li>
<li>languages/cpp/cppduchain/tests/testhelper.cpp <span style="color: grey">(fd58d4b)</span></li>
<li>languages/cpp/cppduchain/usebuilder.cpp <span style="color: grey">(f3f5926)</span></li>
<li>languages/cpp/cppduchain/usedecoratorvisitor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/cppduchain/usedecoratorvisitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/cppparsejob.h <span style="color: grey">(df748cd)</span></li>
<li>languages/cpp/cppparsejob.cpp <span style="color: grey">(2401f6e)</span></li>
<li>languages/cpp/parser/parsesession.h <span style="color: grey">(2859a43)</span></li>
<li>languages/cpp/parser/parsesession.cpp <span style="color: grey">(d3669ff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103140/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>