<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103106/">http://git.reviewboard.kde.org/r/103106/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 73ce55abeec8f6317a6840d2a875d2cfc38d4555 by Florian Zumkeller-Quast to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 10th, 2011, 3:42 p.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2011, 3:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta.
This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Quanta compiles fine with that patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style="color: grey">(e8799f1)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style="color: grey">(4b04725)</span></li>
<li>languages/xml/formatter/sgmlformatter.cpp <span style="color: grey">(4a99d79)</span></li>
<li>languages/xml/language/completion/sgmlcodecompletionmodel.cpp <span style="color: grey">(803760f)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style="color: grey">(8b462bc)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style="color: grey">(761d635)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103106/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>