<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102045/">http://git.reviewboard.kde.org/r/102045/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 22nd, 2011, 9:29 a.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is wrong in all ways possible. Gentoo should just stop trying to break up packages which where never meant to be broken into pieces.
Anyway, at least a find_library call is necessary for this so CMake knows the absolute path to the processui library.</pre>
</blockquote>
<p>On July 22nd, 2011, 9:33 a.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An even better fix would be to make the usage of the process-ui library optional and use the old simple process widget instead when its missing.</pre>
</blockquote>
<p>On July 22nd, 2011, 10:02 a.m., <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm aware of the fact that this isn't a clean fix, but I think the problem should be adressed somehow, so I suggested this.
Okay, so what would you suggest instead? Compiling the tests could just be skipped if that library isn't present, if you think that's a better solution.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you want to address the problem, then get the Gentoo maintainers to fix the config-module that is installed for kde-workspace. Thats a tough job though, been there and failed ;)
Adding a workaround to kdevelop is fine, but then at least find_library needs to be used to find the library if the config module is broken and does not provide the variables, so cmake knows the actual library and can generate proper dependencies and linking does not fail if for some reason the processui library is not in /usr/lib.
The library is not only used for the tests but also for the gdb plugin itself, so making it optional means providing a suitable replacement. Before the dependency on processui was introduced we had our own widget to show the list of processes and select one to attach to, that should still be findable in the history and hence could be resurrected.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On July 22nd, 2011, 8:34 a.m., Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated July 22, 2011, 8:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes a linker error when compiling kdevelop from git on gentoo linux, described here, for example: http://forums.gentoo.org/viewtopic-t-831304-start-0.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, it compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/CMakeLists.txt <span style="color: grey">(55aa261)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>