<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101944/">http://git.reviewboard.kde.org/r/101944/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change should be okay, will end up using the same window as passed before IIRC :)
And sorry for not first bumping the ABI/API version of the Okteta/Kasten libs before doing the first change to the API, did not expect somebody to compile based on that in less than 24 hours :)
Will do the bump next, so the KDevelop buildsystem will no longer pick up the development version of these. Because there will be quite some API changes coming up the next weeks, so for Okteta/Kasten libs from SC 4.8 there rather will be needed a separate version of the plugin.
Expect me to take care of that :)</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On July 13th, 2011, 12:44 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Friedrich W. H. Kossebau.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated July 13, 2011, 12:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since r1241388 kdevelop no longer compiles. This patch fixes compilation by simply removing the obsolete parameter. Not sure if it hurts to not pass it for older okteta versions (it defaults to 0 widget), or if there should be version checks and conditional code.
r1241388: [kdesdk/okteta] Changed: remove QWidget parameter from JobManager::executeJob(...)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles with old and new okteta.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>utils/okteta/oktetadocument.cpp <span style="color: grey">(5ac0311)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101944/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>