<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101852/">http://git.reviewboard.kde.org/r/101852/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8cdf7e60da01d97e4261265cb91164566254f5d2 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 4th, 2011, 11:54 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Giorgos Tsiapaliwkas.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 4, 2011, 11:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Building KDevelop failed for those people who had Okteta (+ headers) installed with another prefix than the one of the kdelibs headers: While the macros will return "Yes, found" the compile will fail as the CamelCase headers will not be found, because in none of the include paths.
Never came around to fix that, but now that Giorgos reminded me of that, here finally a fix for that, by also delivering the include path for the CamelCase headers from the cmake macros to find Okteta/Kasten.
(Also includes an update of the hint where Okteta is to be found, which is kdesdk since 4.6, and removes a no longer needed kdelibs version check)
Okay to also backport to 4.2 branch?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindLibKasten.cmake <span style="color: grey">(2876552)</span></li>
<li>cmake/modules/FindLibOkteta.cmake <span style="color: grey">(0c80168)</span></li>
<li>utils/CMakeLists.txt <span style="color: grey">(f7cb4c8)</span></li>
<li>utils/okteta/CMakeLists.txt <span style="color: grey">(2cc7685)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101852/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>