<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101514/">http://git.reviewboard.kde.org/r/101514/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 26th, 2011, 5:40 p.m., <b>David Nolden</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch also has another problem. All of the pretty HTML highlighting, for example from the Qt documentation, is suddenly gone in the navigation widget. Probably because of the new "span".</pre>
</blockquote>
<p>On June 26th, 2011, 5:50 p.m., <b>David Nolden</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, looking at the screenshots again, there is also no special formatting in the italic version, so the problem is more probably the qt-help support.</pre>
</blockquote>
<p>On June 26th, 2011, 5:57 p.m., <b>David Nolden</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update: There indeed _is_ highlighting lost.
Normally, in the Qt documentation, monospace-fonts are used to highlight example-code as well as enumerator-names and similar. In the example screenshot here it probably doesn't work because the 'span' was already used.</pre>
</blockquote>
<p>On June 26th, 2011, 6:17 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hm actually yeah - I voted "ship it" because I was mainly thinking of non-provider-provided docs, i.e. stuff taken from the editor. There you want/need monospaced as otherwise ASCII-art and other layouting will be broken, which is somewhat common in apidox.
for HTML stuff though, we should take what we get. If qthelp provides us without monospaced stuff, then indeed we should not change that...</pre>
</blockquote>
<p>On June 26th, 2011, 8:41 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, it took me quite some days to actually push it because I wasn't sure about it. I do see that people can't read it in italic so that is definitely bad anyway.
About what it's being said here, well, if we leave it like the provider says so, we'll get the same font everywhere and that's not good either, the eye has to be able to separe what's doc and what's duchain info. Maybe text size? A horizontal line?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've changed it to use the default font (non-fixed non-italic) with a slightly grayed out color, I think it looks good, check it out. Maybe we should make the color even more gray.</pre>
<br />
<p>- David</p>
<br />
<p>On June 6th, 2011, 12:12 a.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 6, 2011, 12:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">here's how it looks like.
Who does prefer it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/duchain/navigation/abstractnavigationcontext.h <span style="color: grey">(9774640)</span></li>
<li>language/duchain/navigation/abstractnavigationcontext.cpp <span style="color: grey">(a067fcf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101514/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101514/s/175/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/06/06/kdevelop-docfont-old_400x100.png" style="border: 1px black solid;" alt="how it looks like" /></a>
<a href="http://git.reviewboard.kde.org/r/101514/s/176/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/06/06/kdevelop-docfont-changed_400x100.png" style="border: 1px black solid;" alt="new version" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>