<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101233/">http://git.reviewboard.kde.org/r/101233/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Olivier Jean de Gaalon.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add move support to cmake, refactor some CMakeLists/ChangesWidget handling bits.
See also the KDevPlatform patch.
Apol:
To preempt your question regarding the reloadFiles function...
Given a a folder (say "folder3") within a folder (say "folder 2") within a folder (say "folder 1").
If you move "folder 3" out of "folder 2", into "folder 1".
::reloadFiles will be called once, and will create a ProjectFolderItem for folder 1
::parse will be called once and will create a CMakeFolderItem for folder 1
::reloadFiles will be called towards the end of ::parse, loop through the project items in the folder, and check them against "entries"
::reloadFiles will find the ProjectFolderItem for "folder 1", and find the string in entries, and remove the string from entries
::reloadFiles will find the CMakeFolderItem for "folder 1", and NOT find the string in entries, and qDeleteAll(), removing both items
::reloadFiles will return to ::parse who will return a QList of the CMakeFolders it created, one of which was just deleted
ImportProjectJob crashes.
The changes to reload files prevent this crash</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">{Adding, removing, moving} in {bulk, various nestings, one-by-one} to/from {targets, folders} repeatedly.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=72921">72921</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/codegen/cppnewclass.cpp <span style="color: grey">(dc4036c)</span></li>
<li>projectmanagers/cmake/cmakemanager.h <span style="color: grey">(78fa569)</span></li>
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(054d488)</span></li>
<li>projectmanagers/custommake/custommakemanager.h <span style="color: grey">(8c2d4d7)</span></li>
<li>projectmanagers/custommake/custommakemanager.cpp <span style="color: grey">(d025537)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101233/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>