<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101054/">http://git.reviewboard.kde.org/r/101054/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look OK, very useful and nice feature.
However, I think it would be better if this was implemented "upstream" within IOpenWith and/or DocumentController::openDocument(..), so that it would also work with command-line arguments and such. In theory, it is also possible to have colons in filenames, so one would first have to make sure that the filename including the colon does not exist.</pre>
<br />
<p>- David</p>
<br />
<p>On April 7th, 2011, 9:02 p.m., Dmitry Risenberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dmitry Risenberg.</div>
<p style="color: grey;"><i>Updated April 7, 2011, 9:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make quickopen able to parse strings formatted to "path to file":"line number" template. When a ProjectFileData item is executed, go to line "line number" after opening the file.
Also export the template parsing function to be used in kdevelop.
See also https://git.reviewboard.kde.org/r/101055/ for changes in kdevelop.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165593">165593</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/interfaces/quickopendataprovider.h <span style="color: grey">(d3dd5f2b031fdc40b92ff76e582e6bd8aa964835)</span></li>
<li>language/interfaces/quickopendataprovider.cpp <span style="color: grey">(5cf185e34678f860af09671acd1411353586320f)</span></li>
<li>plugins/quickopen/projectfilequickopen.cpp <span style="color: grey">(496f8d328d0619d5014f91a20fa9753bd863daab)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101054/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>