<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100949/">http://git.reviewboard.kde.org/r/100949/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 4th, 2011, 9:04 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good now, I prefferr it that way. but I wonder - return code -1? shouldn't it be an int between 1 and 255?</pre>
</blockquote>
<p>On April 4th, 2011, 11:49 a.m., <b>Robert Mathias Marmorstein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The exit status actually gets bitwise anded with the octal value 377, so both -1 and 1 return non-zero. The -1 exit status is a standard for some projects (linux kernel? I forget), while an exit status of "1" is also often used in Unix. Ordinarily it doesn't matter, but using either of the numeric values can cause portability issues. The new standard is to use "EXIT_SUCCESS" and "EXIT_FAILURE" macros to be more portable, so I have changed the code to use "EXIT_FAILURE", tested (it works), and committed.
Thanks!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please add
REVIEW: 100949
or similar (on it's own line) to the commit message next time. that way the review request gets closed automatically and one sees what commit it was.
thanks</pre>
<br />
<p>- Milian</p>
<br />
<p>On April 4th, 2011, 7:35 a.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style="color: grey;"><i>Updated April 4, 2011, 7:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes a crash which occurs when closing kdevelop or quanta after the "KTextEditor::Factory not found" error box is displayed. The problem is a simple logic error caused by the fact that QApplicationCore::exit() does not immediately abort an application. Instead, it causes event processing to cease, which indirectly terminates the application AFTER the function has returned to the main event loop.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Recompiled, ran quanta and kdevelop. Error message dialog still comes up (as it should), but the program closes without crashing now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/partcontroller.cpp <span style="color: grey">(5a81de0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>