<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100807/">http://git.reviewboard.kde.org/r/100807/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2011, 2:28 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100807/diff/1/?file=10608#file10608line337" style="color: black; font-weight: bold; text-decoration: underline;">language/backgroundparser/backgroundparser.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">config.readEntry(entry, oldConfig.readEntry(entry, default))</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">329</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q<span class="hl">Map</span></span><span class="o"><</span><span class="n">KUrl</span><span class="p">,</span> <span class="n">DocumentParsePlan</span> <span class="o">></span> <span class="n">m_documents</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">337</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q<span class="hl">Hash</span></span><span class="o"><</span><span class="n">KUrl</span><span class="p">,</span> <span class="n">DocumentParsePlan</span> <span class="o">></span> <span class="n">m_documents</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is this required or just done to prevent that bug you linked to?
I wonder because afair urls passed to the background parser are not supposed to be relative! hence the description in that bug report you linked to does not apply?</pre>
</blockquote>
<p>On March 6th, 2011, 2:34 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">re-reading your bug report I'd say QMap is even better as "a/b/../c/d" and "a/c/d" is the same after all...</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Non-normalized URLs can go to parser from CMakeLists.txt. For example languages/cpp/tests/CMakeLists.txt has reference to "../cpputils.cpp", which results in "<path>/languages/cpp/tests/../cpputils.cpp", while languages/cpp/CMakeLists.txt refers to it as "<path>/languages/cpp/cpputils.cpp". While they refer to the same file, they might actually have different include paths/defines.
So the QHash/QMap change is required to get the same set of URLs in m_documents and m_documentsForPriority, because QSet and QHash have the same semantics of equality, that different from QMap (at least until it is fixed).</pre>
<br />
<p>- Dmitry</p>
<br />
<p>On March 6th, 2011, 1:51 a.m., Dmitry Risenberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dmitry Risenberg.</div>
<p style="color: grey;"><i>Updated March 6, 2011, 1:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a document was added for parsing with multiple priorities, a default DocumentParsePlan was retrieved from m_documents when creating jobs after the first one. This led to incorrect set of features for parsing job and might trigger unnecessary reparsing when a file was reloaded.
Changed m_documents from QMap to QHash to avoid hitting https://bugs.kde.org/show_bug.cgi?id=267732.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/backgroundparser/backgroundparser.cpp <span style="color: grey">(540a453e74d4a518e54bc9b5fa0c982d76088ea1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100807/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>