<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100802/">http://git.reviewboard.kde.org/r/100802/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, the hunk about the kcfg-file seems wrong/unrelated so remove that. Otherwise the patch is ok, though it might be even nicer if the user could choose the generator on the cmake-builddir-config page so that people using jom can use the specific jom-generator. Oh and of course it should also be possible to generate a VS solution and run that via MS devenv (or whatever the cli-tool for building that was called).</pre>
<br />
<p>- Andreas</p>
<br />
<p>On March 5th, 2011, 4:29 p.m., Andreas Holzammer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.</div>
<div>By Andreas Holzammer.</div>
<p style="color: grey;"><i>Updated March 5, 2011, 4:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Under Windows the standard cmake generator is a Visual Studio Solution. We cannot compile such a solution, so we need to generate a nmake Makefile by standard. This patch adds the generator to the cmake commandline</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to open a cmake project and let him generate a project. worked.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/cmakebuilder/cmakejob.cpp <span style="color: grey">(bd8a76a9835239234e715c212ff8587d0346d7ce)</span></li>
<li>projectmanagers/cmake/CMakeLists.txt <span style="color: grey">(6f8bf025b40acee28f8c54e4d03f09a407e73ed2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100802/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>