<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100616/">http://git.reviewboard.kde.org/r/100616/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 3rd, 2011, 8:09 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've played a bit with it, there is still a bug as you say and I think the solution proposed here is wrong
rather I think the layout should listen to changes in it (or get notified properly) that a dock widget changed, then check it's size limitations for correctness (newly shown dock widget has bigger min width then current width? => relayout)
</pre>
</blockquote>
<p>On March 3rd, 2011, 9:45 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">indeed I think the IdealMainLayout::DockArea and it's width member are to blame, they are simply wrong often.
also //FIXME: adymo: correct implementation would not substract the size in IdealMainLayout::maximumSize must be fixed, it sometimes returns *negative* numbers, esp. if we have the opposite role *hidden*...</pre>
</blockquote>
<p>On March 3rd, 2011, 9:45 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see also: https://bugs.kde.org/show_bug.cgi?id=267314</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">meh I think there is no other way than rewriting parts...
a) DockArea should keep a list of all widgets in it (like it apparently is supposed to but in practice widgets get added/removed all the time - max the one shown is contained in there!)
b) get a proper min value that is the mimum width of all widgets in that area
c) use that to keep track of things</pre>
<br />
<p>- Milian</p>
<br />
<p>On February 16th, 2011, 9:31 p.m., Dmitry Risenberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dmitry Risenberg.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2011, 9:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix a bug with incomplete redrawing of a toolview:
0. Assume "Documents" and "Projects" are both on the left.
1. Click on "Documents" tool.
2. Resize it to minimal width.
3. Click on the "Projects" tool and see a border not redrawn.
Reusing IdealMainLayout::resizeWidget didn't work, because this gets called on initialization when min/max constrains are computed wrong.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sublime/ideal.cpp <span style="color: grey">(ad895619e18a16edc74372fa6135647173dbf35f)</span></li>
<li>sublime/ideallayout.h <span style="color: grey">(308b4efbfbc74070ae482ed965ceb1040c02f236)</span></li>
<li>sublime/ideallayout.cpp <span style="color: grey">(f7b3d25dfa6be9195d5de2297b94fa902e1e35a2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100616/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>