<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100803/">http://git.reviewboard.kde.org/r/100803/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm with Milian on this one, just changing the default make-binary for windows should be enough, no need to duplicate the kcfg file</pre>
<br />
<p>- Andreas</p>
<br />
<p>On March 5th, 2011, 4:32 p.m., Andreas Holzammer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.</div>
<div>By Andreas Holzammer.</div>
<p style="color: grey;"><i>Updated March 5, 2011, 4:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The standard make command is nmake under windows. This patch changes the standard make command under Windows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiled a test project and it worked.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/makebuilder/CMakeLists.txt <span style="color: grey">(e2c599089978dc8e3c4879ca02a92bd725fb9f2f)</span></li>
<li>projectbuilders/makebuilder/makebuilderconfig_msvc.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectbuilders/makebuilder/makebuilderconfig_msvc.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectbuilders/makebuilder/makejob.cpp <span style="color: grey">(fd314516da56a28955793f343ac403e8ef483d4d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>