<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100737/">http://git.reviewboard.kde.org/r/100737/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder whether this is not possibly wasting memory if the contents have been less than reserved. I'd make sure by calling squeeze just before returning the result, see also: http://doc.qt.nokia.com/latest/qvector.html#squeeze
Then please send me the patch as created by "git format-patch" then I'll apply it.
btw: you should apply for a dev account, good work!
</pre>
<br />
<p>- Milian</p>
<br />
<p>On February 24th, 2011, 10:58 p.m., Floris Ruijter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Floris Ruijter.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2011, 10:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">by calling reserve upfront some time is saved. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i did several tests with duchainify on the cpp subtree to find the fastest denominator (it's 10)
no prealloc
real 4m47.104s
user 1m31.478s
sys 0m16.549s
prealloc 1/8
real 4m35.194s
user 1m30.786s
sys 0m16.341s
prealloc 1/9
real 4m34.568s
user 1m30.870s
sys 0m15.917s
prealloc 1/10
real 4m32.682s
user 1m29.150s
sys 0m15.941s
prealloc 1/11
real 4m35.614s
user 1m28.390s
sys 0m15.949s
prealloc 1/12
real 4m39.231s
user 1m27.613s
sys 0m16.209s
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/parser/rpp/chartools.cpp <span style="color: grey">(91612bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100737/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>