<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100734/">http://git.reviewboard.kde.org/r/100734/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Julien Desgats.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2011, 2:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes some problems with cache (including an ininite loop !)
I will merge the whole branch next week, I'm too busy this week end :(</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds support of shadow builds in QMake plugin, made on CMake model. Currently it does :
* Adds a configuration dialog at project creation/import
* Adds support for multiple build configurations (with the same options as config dialog)
* Make a particular folder/target (needs some more work)
* Search for .qmake.cache file from build directory instead of sources
Known issues:
* Some directories and targets does not build on complex projects (this is note directly related on shadow build, is issue is already present on master)
* Data validation in project properties have a weird behavior : if data is invalid, it's not saved but dialog is closed anyway. This is related to KCModule and I can't find a solution to keep dialog open after a click on Ok.
Todo List (can be done later)
* Add parsing QMake command line arguments
* May be use .qmake.cache files instead of command line arguments (like cmake)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Correctness of build directory is unit-tested.
Test has been done on several simple to complex projects (QtCreator) : except on the cases listed previously, running QMake or Make works well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d01acd1)</span></li>
<li>kdevqmakemanager.desktop <span style="color: grey">(03ca19f)</span></li>
<li>qmake.kdev4 <span style="color: grey">(8d796ec)</span></li>
<li>qmakebuilddirchooser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmakebuilddirchooser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmakebuilddirchooser.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmakebuilddirchooserdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmakebuilddirchooserdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmakebuilder/CMakeLists.txt <span style="color: grey">(6790d1a)</span></li>
<li>qmakebuilder/kdevqmakebuilder.desktop <span style="color: grey">(07391df)</span></li>
<li>qmakebuilder/qmakebuilderconfig.kcfg <span style="color: grey">(bc1b059)</span></li>
<li>qmakebuilder/qmakebuilderpreferences.h <span style="color: grey">(a39d446)</span></li>
<li>qmakebuilder/qmakebuilderpreferences.cpp <span style="color: grey">(d8cc507)</span></li>
<li>qmakebuilder/qmakeconfig.ui <span style="color: grey">(2464c19)</span></li>
<li>qmakeconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmakeconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmakejob.h <span style="color: grey">(b00ccf2)</span></li>
<li>qmakejob.cpp <span style="color: grey">(cfae954)</span></li>
<li>qmakemanager.h <span style="color: grey">(ede1e30)</span></li>
<li>qmakemanager.cpp <span style="color: grey">(e0e7042)</span></li>
<li>qmakeprojectfile.h <span style="color: grey">(d0fb1a9)</span></li>
<li>qmakeprojectfile.cpp <span style="color: grey">(8f1b53d)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(80253bc)</span></li>
<li>tests/manual/basic_project/.kdev4/basic_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/basic_project/basic_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/basic_project/basic_project.pro <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/basic_project/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/basic_project/mainwindow.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/.kdev4/subdirs_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/dir_a/dir_a.pro <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/dir_a/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/dir_b/dir_b.pro <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/dir_b/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/subdirs_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/manual/subdirs_project/subdirs_project.pro <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/test_qmakeproject.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/test_qmakeproject.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100734/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>