<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100673/">http://git.reviewboard.kde.org/r/100673/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100673/diff/1/?file=9404#file9404line228" style="color: black; font-weight: bold; text-decoration: underline;">vcs/dvcs/dvcsjob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DVcsJob::slotProcessError( QProcess::ProcessError err )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">222</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d<span class="hl">isplay</span>Output</span><span class="p"><span class="hl">(</span></span><span class="n">d</span><span class="o">-></span><span class="n">childproc</span><span class="o">-></span><span class="n">readAllStandardError</span><span class="p">()<span class="hl">)</span>;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">228</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">error</span>Output</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n">d</span><span class="o">-></span><span class="n">childproc</span><span class="o">-></span><span class="n">readAllStandardError</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this looks like existing plugins need to be adapted, to save their stderr to the new d->errorOutput, right? We need to patch them accordingly once this gets merged.
I don't really understand one thing though: Was this working before? Why does it not work for you? You want to read the stderr in your plugin and -if possible- handle it gracefully? Sounds useful.</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On February 17th, 2011, 1:02 a.m., Andrey Batyiev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andrey Batyiev.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2011, 1:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When some operation fails, command-line tools sometimes put information into stderr. Failures could be recoverable, and it's crucial to VCS plugin to known output from stderr. This patch adds this ability.
Consider:
1. I've it separate from stdout. This prevents any unwanted breakage in existing plugins and allows to separate data streams.
2. This changes interface (but not breaks it).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vcs/dvcs/dvcsjob.h <span style="color: grey">(e0e29ca)</span></li>
<li>vcs/dvcs/dvcsjob.cpp <span style="color: grey">(92c7168)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100673/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>