<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100584/">http://git.reviewboard.kde.org/r/100584/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2011, 9:11 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">while I think we should integrate this, I have to say it's not the technical correct approach. The thing is that it's - theoretically - possible for users to add the project manager toolview multiple times and you only save one setting...
Sadly, the "right" fix would mean some more changes, adding the proper API to the plugin view interface etc...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, we should probably post this somewhere public as a hack though as there are quite some people annoyed by the inability of storing. And the part about the different stretch-factors for treeview vs. buildset really makes sense these days, the project-buildset widget is not necessary that much anymore.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On February 6th, 2011, 9 a.m., Sergey Vidyuk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Vidyuk.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2011, 9 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently ProjectTreeView and ProjectBuildSet widgets have the same size while the first one usually contains much more items then the second one. Every time when I run kdevelop I adjust the splitter position and then start to work. This patch allows to save the sate of the QSplitter in the ProjectManagerView widget in a session and restore it next time you open this session.
I've also added defalt strech factors in order to have 75% for the ProjectTreeView and 25% for the ProjectBuildSet for a new sessions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following things are tested manually:
1 New session have correct splitter position (75%:25%).
2 Splitter position is saved restored correctly for different sessions.
3 Sessions created before this patch are loaded correctly and splitter position is set to the default value.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(1149282)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100584/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>