<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100367/">http://git.reviewboard.kde.org/r/100367/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 12th, 2011, 5:50 p.m., <b>David Nolden</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree on the comments from Milian. The changes to expressionAt are a bit hard to comprehend, please add some explanations for them.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I'll add a comment, but basically given:
"if (int i > 0)" expressionAt will return everything from indice 0 to the '>', because it considers '>' to be a template bracket, and tries to find the other end. My changes basically just make sure that if it doesn't find it, it gives you an empty expression.
The problem with returning everything from 0 to '>' is that it's impossible to differentiate between the times that's correct (which are vanishingly few), and the times when it's just trying to annoy me.
I made the same changes to the '{' bracket and the '(' bracket matching just for consistency, but it actually shouldn't be done with the '(' bracket, thus the commented out part which I forgot to remove.</pre>
<br />
<p>- Olivier Jean de</p>
<br />
<p>On January 12th, 2011, 3:51 a.m., Olivier Jean de Gaalon wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Olivier Jean de Gaalon.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2011, 3:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactoring and bugfixing for the cpp code completion context + tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">About a week of use and writing tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/codecompletion/context.h <span style="color: grey">(dd7416f)</span></li>
<li>languages/cpp/codecompletion/context.cpp <span style="color: grey">(79e0bf3)</span></li>
<li>languages/cpp/codecompletion/helpers.cpp <span style="color: grey">(125739a)</span></li>
<li>languages/cpp/codecompletion/item.cpp <span style="color: grey">(5fea5fd)</span></li>
<li>languages/cpp/stringhelpers.cpp <span style="color: grey">(ace90e6)</span></li>
<li>languages/cpp/tests/test_cppcodecompletion.h <span style="color: grey">(f2e50b7)</span></li>
<li>languages/cpp/tests/test_cppcodecompletion.cpp <span style="color: grey">(8218346)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100367/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>