<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100283/">http://git.reviewboard.kde.org/r/100283/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 9th, 2011, 5:38 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please commit it to git - I have no access to do that. Also it would be good to have it in 4.1.2, so maybe it should be backported to 4.1 branch.</pre>
<br />
<p>- Valentyn</p>
<br />
<p>On January 3rd, 2011, 4:19 p.m., Valentyn Pavliuchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Valentyn Pavliuchenko.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2011, 4:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Both file(GLOB) and file(GLOB_RECURSE) parsers were fixed to behave as CMake does (reimplemented properly). Added FOLLOW_SYMLINKS parameter to GLOB_RECURSE. Fixed RELATIVE behavior. Added glob expressions support in directory names in the path, as CMake supports it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done manual testing. Added appropriate unit test. Unit test passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/parser/cmakeast.h <span style="color: grey">(54a52d0)</span></li>
<li>projectmanagers/cmake/parser/cmakeast.cpp <span style="color: grey">(7e40013)</span></li>
<li>projectmanagers/cmake/parser/cmakedebugvisitor.cpp <span style="color: grey">(03a0d8c)</span></li>
<li>projectmanagers/cmake/parser/cmakeprojectvisitor.h <span style="color: grey">(a825d2b)</span></li>
<li>projectmanagers/cmake/parser/cmakeprojectvisitor.cpp <span style="color: grey">(e2f16d1)</span></li>
<li>projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.h <span style="color: grey">(b16b16f)</span></li>
<li>projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.cpp <span style="color: grey">(638b7d0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100283/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>