<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100283/">http://git.reviewboard.kde.org/r/100283/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd rather you create the test file tree directly in the unit test using e.g. KTempDir & KTemporaryFile, instead of shipping that in the source tree.</pre>
<br />
<p>- Milian</p>
<br />
<p>On January 1st, 2011, 11:06 p.m., Valentyn Pavliuchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Valentyn Pavliuchenko.</div>
<p style="color: grey;"><i>Updated 2011-01-01 23:06:14</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Both file(GLOB) and file(GLOB_RECURSE) parsers were fixed to behave as CMake does (reimplemented properly). Added FOLLOW_SYMLINKS parameter to GLOB_RECURSE. Fixed RELATIVE behavior. Added glob expressions support in directory names in the path, as CMake supports it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done manual testing. Added appropriate unit test. Unit test passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/tests/cmakeglobtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/cmakeglobtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/CMakeLists.txt <span style="color: grey">(4de0ce0)</span></li>
<li>projectmanagers/cmake/parser/cmakeast.h <span style="color: grey">(54a52d0)</span></li>
<li>projectmanagers/cmake/parser/cmakeast.cpp <span style="color: grey">(7e40013)</span></li>
<li>projectmanagers/cmake/parser/cmakedebugvisitor.cpp <span style="color: grey">(03a0d8c)</span></li>
<li>projectmanagers/cmake/parser/cmakeprojectvisitor.h <span style="color: grey">(a825d2b)</span></li>
<li>projectmanagers/cmake/parser/cmakeprojectvisitor.cpp <span style="color: grey">(e2f16d1)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/1/g.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/1/h.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/2/d.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/GLOB_RECURSE_SOURCES1.var <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/GLOB_RECURSE_SOURCES2.var <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/GLOB_SOURCES1.var <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/GLOB_SOURCES2.var <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/subdir/1/c.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/subdir/2 <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/subdir/a.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/subdir/b.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/subdir1/1 <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/subdir1/e.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/file_glob/subdir1/f.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100283/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>