<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100252/">http://git.reviewboard.kde.org/r/100252/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Nathanaël Restori.</div>
<p style="color: grey;"><i>Updated 2010-12-29 17:44:58.534696</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New patch with asked changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch convert every QPointer in QWeakPointer
In the bug report, Millan Wolff says : "it shows that in GDB the pointer was used quite a lot without being checked,
you should do that at the start of each function, or at least Q_ASSERT on it." but for hardly every function, there is a "Q_ASSERT(thePointer)", a "if (thePointer)" or a "if (!thePointer)"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only try to compile.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260586">260586</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/debuggerplugin.h <span style="color: grey">(9144d25)</span></li>
<li>debuggers/gdb/debugsession.h <span style="color: grey">(4abbc11)</span></li>
<li>debuggers/gdb/debugsession.cpp <span style="color: grey">(b050db2)</span></li>
<li>debuggers/gdb/gdbcommand.h <span style="color: grey">(63c4c34)</span></li>
<li>debuggers/gdb/gdbcommand.cpp <span style="color: grey">(c46f0ec)</span></li>
<li>debuggers/gdb/gdbvariable.cpp <span style="color: grey">(8e47f6e)</span></li>
<li>debuggers/gdb/unittests/gdbtest.cpp <span style="color: grey">(41980e9)</span></li>
<li>languages/cpp/codecompletion/model.h <span style="color: grey">(84c1e1e)</span></li>
<li>languages/cpp/codegen/codeassistant.h <span style="color: grey">(a5cbeb8)</span></li>
<li>languages/cpp/codegen/codeassistant.cpp <span style="color: grey">(c9a3673)</span></li>
<li>languages/cpp/codegen/unresolvedincludeassistant.cpp <span style="color: grey">(9c5872b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100252/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>