<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100225/">http://git.reviewboard.kde.org/r/100225/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 23rd, 2010, 11:27 p.m., <b>Floris Ruijter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i'd say it should be a shared pointer, since the plugin will now be almost immediately after the assignment be deleted, since weakpointer has no assignment from T* so it is assigned a coerced T* to sharedpointer, wich will delete the contents afterwards (very soon) then you have quite some lines down a use of the data() member which is not a member of weakpointer, but is of sharedpointer.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i was looking at the wrong manual version. looking at the new manual one can see nothing's wrong</pre>
<br />
<p>- Floris</p>
<br />
<p>On December 21st, 2010, 1:05 p.m., Dmitry Risenberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Dmitry Risenberg.</div>
<p style="color: grey;"><i>Updated 2010-12-21 13:05:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Store a QWeakPointer to version control plugin in ProjectPrivate, so that it can track deletion.
No checking for FileManager unloading, because it seems to be a mandatory plugin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/project.cpp <span style="color: grey">(c8fbc53)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100225/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>