<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100192/">http://git.reviewboard.kde.org/r/100192/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 7th, 2010, 12:02 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good first start and can be applied imo.
it would be nice to reuse KTextEditor::TemplateInterface for this though. That would require an open document though, so not sure. Probably overkill for simple licenses.
Alternatively using Grantlee would be awesome as well, yet again - maybe overkill :)
So as I said, please merge into master (if you have commit rights)</pre>
</blockquote>
<p>On December 7th, 2010, 4:51 p.m., <b>Jan Gerrit Marker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great, thanks :-).
I noticed that I don't check if name or email address are empty, I'll add a placeholder like the one before if they are, ok?.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">check that before you are trying to do the replacement, i.e. don't replace anything when the email/name/... is empty.</pre>
<br />
<p>- Milian</p>
<br />
<p>On December 6th, 2010, 9:48 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated 2010-12-06 21:48:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you create a new class using the KDevelop code generator there will be added a license. Normally these licenses have a "<year>" and a "<copyright holder>" (or similar) in it. You have to replace this manually. This patch replaces "<year>" and "<copyright holder>" with the appropiate texts - the year is taken from QDate the name and email from KEMailSettings. The name has the format "My Name <myemail@example.com>".
The licenses are changed to use only "<year>" and "<copyright holder>".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works fine for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/codegen/licenses/LGPL <span style="color: grey">(0b542d1)</span></li>
<li>language/codegen/licenses/MIT <span style="color: grey">(03cadb0)</span></li>
<li>language/codegen/licenses/GPL <span style="color: grey">(77f9410)</span></li>
<li>language/codegen/licenses/GPL <span style="color: grey">(17dbc21)</span></li>
<li>language/codegen/licenses/Apache <span style="color: grey">(fbf1e16)</span></li>
<li>language/codegen/createclass.cpp <span style="color: grey">(7685e03)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100192/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>