<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100179/">http://git.reviewboard.kde.org/r/100179/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andreas Pakulat.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add an additional version check to prevent projects using kdevplatform from running into compile problems due to incompatible API.
KDevPlatform currently breaks its API with each minor release, so a project that was built against KDevPlatform 1.1.0 may easily break when someone tries
to compile it against KDevPlatform 1.2 (1.1.60 or later). As we can already somewhat detect this during cmake time and give a nice error message instead
of the user having to hunt down the compiler errors we should do that IMHO.
This change checks the found KDevPlatform version to be less than find-version-major.find-version-minor.60, i.e. if a project has the required version set
to 1.0.0 and someone tries to build it with KDevPlatform 1.1.0 installed he'll get an error message.
This is not 100% perfect:
- If a project doesn't supply a version number, we cannot do the check (note to self: test this case)
- If a project wants to support 2 versions of KDevPlatform at the same time, this change will prevent that
We could think about allowing to set a KDEVPLATFORM_OVERRIDE_STRICT_VERSION_CHECK cmake variable before calling find_package(KDevPlatform 1.1.0) to support
the second point from above. Opinions?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built KDevPlatform 1.1 branch with this change and tried kdevelop4-custom-buildsystem with adjusted find_package call to require KDevPlatform 1.0.0. Fails as expected, changing back to require KDevPlatform 1.1 makes the cmake call work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDevPlatformConfig.cmake.in <span style="color: grey">(dfd16fcc90527b7d3ded94eace780e486ec52bfa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100179/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>