<div class="gmail_quote">On Wed, Aug 25, 2010 at 11:16 PM, Aleix Pol <span dir="ltr"><<a href="mailto:aleixpol@kde.org">aleixpol@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div><div></div><div class="h5">On Wed, Aug 25, 2010 at 4:03 PM, Niko Sams <span dir="ltr"><<a href="mailto:niko.sams@gmail.com" target="_blank">niko.sams@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
I get this crash when executing Save As... for a file:<br>
Thread 1 (Thread 0x7f150cecc760 (LWP 23145)):<br>
[KCrash Handler]<br>
#4 0x00007f14e70ce530 in VcsProjectIntegrationPlugin::changes<br>
(this=0x5072e80, project=0x0, urls=@0x7fff262dc9d0,<br>
mode=KDevelop::IBasicVersionControl::NonRecursive)<br>
at /home/niko/kdesvn/kdevelop4-extra-plugins/vcsprojectintegration/vcsprojectintegrationplugin.cpp:132<br>
#5 0x00007f14e70ce838 in VcsProjectIntegrationPlugin::documentSaved<br>
(this=0x5072e80, document=0x451b6a0)<br>
at /home/niko/kdesvn/kdevelop4-extra-plugins/vcsprojectintegration/vcsprojectintegrationplugin.cpp:103<br>
#6 0x00007f14e70cd5d7 in VcsProjectIntegrationPlugin::qt_metacall<br>
(this=0x5072e80, _c=QMetaObject::InvokeMetaMethod, _id=2,<br>
_a=0x7fff262dcb10)<br>
at /home/niko/kdesvn/build/kdevelop4-extra-plugins/vcsprojectintegration/moc_vcsprojectintegrationplugin.cpp:83<br>
#7 0x00007f1509960296 in QMetaObject::activate () from<br>
/usr/lib64/qt4/libQtCore.so.4<br>
#8 0x00007f150c68fc3d in KDevelop::IDocumentController::documentSaved<br>
(this=0x87f3b0, _t1=0x451b6a0) at<br>
/home/niko/kdesvn/build/kdevplatform/interfaces/idocumentcontroller.moc:230<br>
#9 0x00007f150c68c600 in KDevelop::IDocument::notifySaved<br>
(this=0x451b6a0) at<br>
/home/niko/kdesvn/kdevplatform/interfaces/idocument.cpp:69<br>
#10 0x00007f150c3d86ce in KDevelop::TextDocumentPrivate::documentSaved<br>
(this=0x4fafea0, document=0x7ef1a70, saveAs=false) at<br>
/home/niko/kdesvn/kdevplatform/shell/textdocument.cpp:181<br>
(Using git)<br></blockquote><div><br></div></div></div><div>Fixed :)</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I actually like the idea of having a separate toolview - it's like a<br>
"git status" toolview.<br>
<br>
Issues I had:<br>
- it doesn't update always<br></blockquote></div><div>Yep, I'll have to intercept the vcs job's when they're done somehow, I guess that I will have to check the finished jobs in the runcontroller and check if there's an update/pull/commit/...</div>
<div class="im">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- there is no refresh button to update manually<br></blockquote></div><div>When the update action happens outside KDevelop we will want to reload manually in most cases, yes. I agree that's missing and it's one of the first features that should be added.</div>
<div class="im">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
suggestions:<br>
- use the file context menu<br></blockquote></div><div>+1</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- double click should show the diff or whatever is relevant to the change<br></blockquote></div><div>good idea, didn't think about that.</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#888888"><br>
<br>
Niko<br>
</font><div><div></div><div><br>
On Mon, Aug 23, 2010 at 20:30, Aleix Pol <<a href="mailto:aleixpol@kde.org" target="_blank">aleixpol@kde.org</a>> wrote:<br>
> Hi,<br>
> I revived that plugin I was working on during the last KDevelop meeting, now<br>
> it's a new toolview that displays what changes we have in every project we<br>
> have opened. It's quite useful to be able to see what's the work we have.<br>
> The only very important thing to put is a context menu to expose some<br>
> important actions.<br>
> It still needs some love so I won't push it for 4.1 but I think it can be a<br>
> good thing to have in 4.2. If you have any interest on that please test it<br>
> and tell me what do you think.<br>
> Cheers!<br>
> Aleix<br>
</div></div>> --<br>
<div><div></div><div>> KDevelop-devel mailing list<br>
> <a href="mailto:KDevelop-devel@kdevelop.org" target="_blank">KDevelop-devel@kdevelop.org</a><br>
> <a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
><br>
><br>
<br>
--<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org" target="_blank">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
</div></div></blockquote></div></div><br>
</blockquote></div><br><div>I added the context menu and the reload item (in the context menu, maybe it should go to the toolview... hm).</div><div>I'll see what we do on doubleclick.</div><div><br></div><div>Aleix</div>