<br><br><div class="gmail_quote">2009/3/27 Andreas Pakulat <span dir="ltr"><<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On 27.03.09 10:50:23, Fabian Wiesel wrote:<br></div><div class="im"><br>
</div>I just meant that you should use diff -u when creating the diff, which will<br>
use this format: <br></blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">[...]<br>
which I personally find awkward to read. Its fine to post only parts of the<br>
whole patch.</blockquote><div> </div><div>Will do so next time.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">
> This may be a reason why VcsMapping came into existence, but it doesn't<br>
> negate the problems I cited.<br>
> What does one gain by batching all the checkouts? And is it sensible to<br>
> require all but one VCS to re-implement said capability?<br>
<br>
</div>A VCS doesn't need to re-implement that capability. In fact it shouldn't<br>
and (unless I was drunk when writing it) Subversion only uses the first<br>
entry from the mapping and ignores everything else.<br>
</blockquote><div><br>I think, that's the worst solution. Not only breaks the abstraction a interface is supposed to provide, such an <br>implementation also falsely claims, that it executed the command I requested correctly, while it didn't.<br>
The only reason, why this hasn't failed fataly is, because all the callers are just using the subset of the interface I suggested.<br><br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">[...]
Its comparable to an svn:external that is set only locally inside that<br>
checkout. </blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">The VcsMapping is a description of how to create 1 checkout directory from<br>
1-n repository places.<br>
</blockquote></div><br>Not only does it n checkouts, it also creates a references in the working directory similar to svn:externals.<br>So, additionally of being specific to perforce, it seems to me a text-book example of a non-orthogonal function.<br>
<br>Fabian<br><br>