<br><br><div class="gmail_quote">On Wed, Feb 11, 2009 at 5:56 PM, Andreas Pakulat <span dir="ltr"><<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On 11.02.09 16:32:48, Aleix Pol Gonzalez wrote:<br>
> SVN commit 924800 by apol:<br>
><br>
> Look for libraries in a more cmake-friendly way.<br>
> When dealing with paths, give the current path as a path base for relative paths.<br>
> Fix some errors added yesterday and pointed out by apaku.<br>
><br>
><br>
>  M  +5 -2      cmakecondition.cpp<br>
>  M  +8 -2      cmakeprojectvisitor.cpp<br>
><br>
><br>
> --- trunk/KDE/kdevelop/plugins/managers/cmake/parser/cmakecondition.cpp #924799:924800<br>
> @@ -149,17 +149,20 @@<br>
>              case EXISTS:<br>
>              {<br>
>                  QString v=*(it2+1);<br>
> -//                 kDebug(9042) << "EXISTS" << v << *it2;<br>
>                  if(v.isEmpty())<br>
>                      kDebug(9042) << "error: no parameter to exist";<br>
>                  else<br>
>                  {<br>
>                      last=false;<br>
> -                    QFileInfo f(v);<br>
> +                    QString dir;<br>
> +                    if(m_vars->contains("CMAKE_CURRENT_SOURCE_DIR"))<br>
> +                        dir=m_vars->value("CMAKE_CURRENT_SOURCE_DIR").first();<br>
> +                    QFileInfo f(dir, v);<br>
<br>
</div>Isn't this the same problem as the current-source-dir thing from your last<br>
commit? That is if the argument is already an absolute path this will now<br>
fail.<br>
<br>
Andreas<br>
<font color="#888888"><br>
--<br>
It's all in the mind, ya know.<br>
<br>
_______________________________________________<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
</font></blockquote></div><br>It is fine, just added tests for that.<br>