D15743: Fix removal of external scripts

Amish Naidu noreply at phabricator.kde.org
Wed Sep 26 11:39:07 BST 2018


amhndu added inline comments.

INLINE COMMENTS

> externalscriptplugin.cpp:392
> +{
> +  QSet<QString> keySet;
> +  for ( int row = 0; row < m_model->rowCount(); ++row ) {

Would this better be a member ?
Will save the time required to create a new set each call.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15743

To: amhndu, #kdevelop
Cc: flherne, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180926/b1dc357b/attachment-0001.html>


More information about the KDevelop-devel mailing list