D16032: Generate all kdebugsettings .categories files automatically

[Aleix Pol Gonzalez]

apol added a comment.


  Considering we're doing our own macro, we can be also more succint. I don't see why we can't have `declare_plugin_qt_logging_category(targetname)`
  
  You can use `target_sources()` instead of adding it to the variable.

INLINE COMMENTS

> KDevelopMacrosInternal.cmake:336
> +# Needs to be called after the last declare_plugin_qt_logging_category & declare_app_qt_logging_category call.
> +function(install_app_plugin_qt_logging_categories)
> +    _install_qt_logging_categories(

Wouldn't it be better to just add the install call in the declare_*_qt_logging_category calls? This way we wouldn't need a magical function call in the root CMakeLists.txt file.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16032

To: kossebau, #kdevelop
Cc: apol, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181010/b704fd82/attachment.html>