D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools.

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.


  Ah, right, I missed that part. The problem is that VS2017 by default doesn't set `VS150COMNTOOLS` as system-wide env variable.
  
  @Petross404 Maybe, for the time being, something like this here could help:
  https://github.com/dotnet/roslyn-analyzers/commit/f9ee28e16f253a7da9eee6f45e32251a41adb538 (just the if-cascade at the bottom, and without the `if "%VS150COMNTOOLS%" EQU "" ` obviously)
  
  Would you want to give this a try?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15976

To: Petross404, #kdevelop, kfunk
Cc: kfunk, arrowd, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181008/d17297af/attachment.html>