D15606: Fix calling qdbus by using qt5-current name qdbus-qt5

[Kevin Funk]

kfunk added inline comments.

INLINE COMMENTS

> kfunk wrote in kdevplatform_shell_environment.sh:74
> Shouldn't this prefer `qdbus-qt5` over `qdbus`, too?

> I preferred qdbus over qdbus-qt5, as the latter seems he exception. But no fixed opinion, there are arguments for both orders.

Reasoning here: qdbus could resemble the Qt4-Version of qdbus in case there are multiple installs of Qt; qdbus-qt5 never is. Thus using qdbus-qt5 as first option is more fail-safe.

> Why, the too

Well, `kdevelop!` first checks qdbus-qt5 -- but otoh order is not important there.

> I used _qdbus to follow _shell, but then the naming patterns seems not consistent.

Ah, okay, that wasn't obvious from the diff: Use whatever you prefer, and what appears consistent in this file. `_qdbus` then, if you prefer.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15606

To: kossebau, #kdevelop, lbeltrame, fvogt, jriddell, kfunk
Cc: kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181004/9e1e27e5/attachment.html>