D9344: [KDevelop] : consistent use of the project name (WIP)

René J.V. Bertin noreply at phabricator.kde.org
Sat Jul 7 09:33:59 BST 2018


rjvbb updated this revision to Diff 37281.
rjvbb added a comment.


  This should now work as intended in all situations.
  
  I had not realised that the project name validation function was also already getting called during the project selection stage, which led to corrupting `m_url` because both functions were modifying it recursively. Except when importing a cmake or qmake file from the project toplevel directory.
  
  Please double-check.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9344?vs=33322&id=37281

REVISION DETAIL
  https://phabricator.kde.org/D9344

AFFECTED FILES
  kdevplatform/shell/openprojectdialog.cpp
  kdevplatform/shell/openprojectdialog.h
  kdevplatform/shell/projectcontroller.cpp

To: rjvbb, #kdevelop, mwolff
Cc: mschwarz, kfunk, mwolff, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180707/f418d1af/attachment-0001.html>


More information about the KDevelop-devel mailing list