D14931: Eliminate duplicate QMaps in OutputWidget

Vyacheslav Korneev noreply at phabricator.kde.org
Thu Aug 23 20:27:19 BST 2018


vkorneev added inline comments.

INLINE COMMENTS

> kfunk wrote in outputwidget.cpp:278
> I think this line is redundant. You're doing `m_views.remove(id);` outside the if-else stmt anyway(?)

Yes, thanks, it's redundant, it leaked into the code because I was thinking about the issue, described in the TODO comment below. I'll remove it now.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14931

To: vkorneev, #kdevelop
Cc: kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180823/4045176f/attachment-0001.html>


More information about the KDevelop-devel mailing list