D8990: In eventFilter() pass on to base class and only eat events when needed

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Nov 24 22:47:39 UTC 2017


kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Clazy pointed out some overly greedy eventFilter() implementations.
  No bugs uncovered by this, but feels better to not ignore possible needs of
  base classes as well as other instances being interested in events.

REPOSITORY
  R32 KDevelop

BRANCH
  dontstealeventsineventfilter

REVISION DETAIL
  https://phabricator.kde.org/D8990

AFFECTED FILES
  kdevplatform/shell/sessionchooserdialog.cpp
  plugins/projectfilter/projectfilterconfigpage.cpp
  plugins/quickopen/quickopenplugin.cpp
  plugins/quickopen/quickopenwidget.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171124/7780c72f/attachment.html>


More information about the KDevelop-devel mailing list