D4981: patchreview : allow choice of the number of context lines

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D4981#93948, @rjvbb wrote:
  
  > In https://phabricator.kde.org/D4981#93946, @apol wrote:
  >
  > > I'm sorry, but I don't see when this is useful.
  >
  >
  > That's described in the summary. You may not believe those arguments but they're not invented. Also see the May 12th 2014 comment on https://secure.phabricator.com/T5029 ; a large enough number of context lines is the "official" way to upload useful raw patches to Phab .
  >
  > The patch has many small changes but I don't think that any of them is complicated and hard to maintain, should be apply and mostly forget.
  
  
  No, but it all adds complexity.
  
  If we need more context on the git patches, I'd add it right away on git plugin. No need to abstract it on the whole architecture.

REVISION DETAIL
  https://phabricator.kde.org/D4981

To: rjvbb, #kdevelop
Cc: apol, kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170309/4f31612a/attachment.html>