D7171: Documentation toolview: restore custom context menu on page view

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon Aug 7 04:35:33 UTC 2017


kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  The widget wrapper added for hiding the implementation choice
  between QWebEngine or QWebKit broke the custom context menu setting,
  as any calls to set contextMenuPolicy of a StandardDocumentationView
  object, like in QtHelpDocumentation::documentationWidget(), no longer
  affected the web view itself.
  
  This patch restores that (and ensures the basic custom menu also with
  non-QtHelpDocumentation users of StandardDocumentationView, like by
  plucings for man-pages or cmake).
  
  The change from exposing copyAction() to createStandardContextMenu()
  should allow extending the base menu (e.g. by find-text action)
  without menu extending classes like QtHelpDocumentation having
  to know about it.

REPOSITORY
  R33 KDevPlatform

BRANCH
  restorecustomdocumentationcontextmenu

REVISION DETAIL
  https://phabricator.kde.org/D7171

AFFECTED FILES
  documentation/standarddocumentationview.cpp
  documentation/standarddocumentationview.h

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170807/a4fcbf53/attachment.html>


More information about the KDevelop-devel mailing list