Review Request 128188: [OS X] Show job progress with Dock icon badge

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128188/#review96499
-----------------------------------------------------------


Ship it!




LGTM

Screenshot maybe?

- Kevin Funk


On June 14, 2016, 6:42 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128188/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 6:42 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is a follow-up to https://git.reviewboard.kde.org/r/127050/, providing a job progress indication in the Dock (and app switcher), by badging the application icon.
> 
> Is it correct that the `RunController` is not used by the (Clang) parser? If so, shouldn't this progress indication (and the Unity one) be moved to the method that updates the progress bar in KDevelop's lower right corner?
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 19a9560 
>   shell/runcontroller.cpp 1a411da 
> 
> Diff: https://git.reviewboard.kde.org/r/128188/diff/
> 
> 
> Testing
> -------
> 
> Works on OS X 10.9.5 with Qt 5.6.0 and frameworks 5.22.0
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160614/7b501347/attachment.html>