Review Request 129649: Add browser selection dialog

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129649/#review101442
-----------------------------------------------------------




browserappconfig.cpp (line 104)
<https://git.reviewboard.kde.org/r/129649/#comment67920>

    Should this not be inside the block above? If the dialog was canceled, nothing changed.


- Kevin Funk


On Dec. 14, 2016, 2:01 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129649/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 2:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-executebrowser
> 
> 
> Description
> -------
> 
> Add browser selection dialog
> 
> 
> Diffs
> -----
> 
>   browserappconfig.h 9862d3424e22b41e8076e34558ecef6ab2868b45 
>   browserappconfig.cpp d11fff929fef9e5c0efb914435d615c979087eeb 
>   browserappconfig.ui a8d940e78c2794609c483cbd9c02be8d1b947bf2 
> 
> Diff: https://git.reviewboard.kde.org/r/129649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161214/3e493ba6/attachment.html>