Review Request 123715: Enable highlighting of declarations/uses in the DUContext::Other contexts

[Olivier Jean de Gaalon]

> On May 11, 2015, 9:23 a.m., Milian Wolff wrote:
> > will this add rainbow colors for global declarations or namespace declarations? that should not happen (we never did that in oldcpp). so maybe its enough to do it only for ::Function type contexts?

Those should be in Global or Namespace type context, I believe. We cannot do it in Function types only, as that only includes the function arguments (the body is in an Other context inside the Function context).
The closest mapping to the old behavior afaik would be type == Function or parent->type == Function, but as I said, I think I'd be in favor of having it go deeper than that (ie, all Other contexts). Unless I'm forgetting an Other context which we don't want for some reason...


- Olivier Jean de


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123715/#review80208
-----------------------------------------------------------


On May 10, 2015, 3:01 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123715/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 3:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> The highlighting code in kdevplatform expects that the DUContext::Other contexts are owned by the declarations, but this is not the case for the kdev-clang, as we don't use internalFunctionContext's and set DUContext::Function contexts as internalContexts instead.
> 
> 
> Diffs
> -----
> 
>   clanghighlighting.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150511/86dfadfd/attachment.html>