Review Request 113786: Fix Ctrl+B Shortcut (add bookmark) while Filesystem toolview is open

[Niko Sams]

> On Jan. 14, 2014, 10:42 a.m., Milian Wolff wrote:
> > Could you instead try to set Qt::WidgetWithChildrenShortcut shortcutContext (and verify that the parentWidget is correct)?
> > 
> > Removing the shortcuts sounds wrong to me :(

I tried that, doesn't work.

And I think this is an action that won't get used that often - so it doesn't need it's own shortcut.


- Niko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113786/#review47360
-----------------------------------------------------------


On Nov. 10, 2013, 3:50 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113786/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 3:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> steps to reproduce the issue:
> - open filesystem toolview
> - focus editor and press Ctrl+B to add a bookmark
> - watch errormessage "The key sequence 'Ctrl+B' is ambiguous..."
> 
> Ctrl+B is also used in the bookmark menu for Add Bookmark.
> 
> This patch fixes the problem by removing all shortcuts.
> 
> 
> Diffs
> -----
> 
>   plugins/filemanager/bookmarkhandler.cpp 565cc28 
> 
> Diff: https://git.reviewboard.kde.org/r/113786/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140116/cb45e702/attachment-0001.html>