Review Request 119898: Fix sizeHint for IdealToolButton

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119898/#review65051
-----------------------------------------------------------

Ship it!


does this also affect master/1.7 branches? if so - please put it there first then it will get merged up into the other branches.

- Milian Wolff


On Aug. 22, 2014, 1:27 p.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119898/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 1:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> As title says:
> use sizeFromContents from style rather than fixed spacing and margin, to get the correct size hint. This is similar to what is done in QToolButton and fixes truncated text for styles that add extra spacing (consistently with sizeFromContents) when rendering toolbuttons (this is the case for breeze)
> 
> Note: this also removes a "FIXME" comment
> 
> 
> Diffs
> -----
> 
>   sublime/idealtoolbutton.cpp abecdca 
> 
> Diff: https://git.reviewboard.kde.org/r/119898/diff/
> 
> 
> Testing
> -------
> 
> Tested with oxygen, breeze and fusion.
> 
> 
> File Attachments
> ----------------
> 
> kdevelop-before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/352aa1d1-84d1-4fa2-8e01-3f5a8e33e9db__kdevelop-before.png
> kdevelop-after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/beaeb568-f2f8-440c-a4e8-101e1e6c1499__kdevelop-after.png
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140822/f5a56c2d/attachment.html>