Review Request 109562: When a user has ( in the project name, use an alternative

Aleix Pol Gonzalez aleixpol at gmail.com
Wed Mar 20 18:40:44 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109562/
-----------------------------------------------------------

(Updated March 20, 2013, 6:40 p.m.)


Review request for KDevelop.


Changes
-------

Custom painting of the delegate's text, move the branch name to a different role.


Description
-------

If there's ( in the project name, use [.

Then it will look like "Project Name (some thing) [master]".


Diffs (updated)
-----

  plugins/projectmanagerview/CMakeLists.txt 93971e2 
  plugins/projectmanagerview/projectmodelitemdelegate.h PRE-CREATION 
  plugins/projectmanagerview/projectmodelitemdelegate.cpp PRE-CREATION 
  plugins/projectmanagerview/projecttreeview.cpp 4f9b5ae 
  plugins/projectmanagerview/vcsoverlayproxymodel.h 35f98bc 
  plugins/projectmanagerview/vcsoverlayproxymodel.cpp b414868 
  project/projectmodel.h 909b6d6 

Diff: http://git.reviewboard.kde.org/r/109562/diff/


Testing
-------


File Attachments (updated)
----------------

Result
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/18/kdevelop-peoplehaveparenthesisinprojectnames.png
custom delegate
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/kdevelop-peoplehaveparenthesisinprojectnames1.png
very custom delegate
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/20/kdevelop-peoplehaveparenthesisinprojectnames2.png


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130320/951fe41c/attachment-0001.html>


More information about the KDevelop-devel mailing list