Review Request 110298: added kdevplatform part of kdevelop zsh integration

[Phil Schaf]

> On July 27, 2013, 1:56 p.m., Milian Wolff wrote:
> > util/kdevplatform_shell_environment.sh, line 33
> > <http://git.reviewboard.kde.org/r/110298/diff/3/?file=142267#file142267line33>
> >
> >     this does not load the ~/.bashrc anymore, as the old code used to do - why? looking at the contents, this file loads my .bashrc - is this "documented" / "indented" behavior and we can rely on that to keep backwards compatibility?
> >     
> >     generally though, shouldn't one _first_ load the global stuff and then "overwrite" that by the local configuration?

fixed. i don’t know why i left it out initially, it’s been some time.

and as far as i can see it does exactly that: it sources the default files, then makes alterations on top of those.


- Phil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110298/#review36596
-----------------------------------------------------------


On July 28, 2013, 11:09 a.m., Phil Schaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110298/
> -----------------------------------------------------------
> 
> (Updated July 28, 2013, 11:09 a.m.)
> 
> 
> Review request for KDevelop and David Nolden.
> 
> 
> Description
> -------
> 
> added kdevplatform part of kdevelop zsh integration
> 
> sister review of https://git.reviewboard.kde.org/r/110299/
> 
> 
> Diffs
> -----
> 
>   util/.zshrc PRE-CREATION 
>   util/CMakeLists.txt 29de12617b4e9d7697abc73465ed435b9039c531 
>   util/kdevplatform_shell_environment.sh d2ece7f9286f8cb8ae35c672a29d5248e2c1a199 
> 
> Diff: http://git.reviewboard.kde.org/r/110298/diff/
> 
> 
> Testing
> -------
> 
> I don’t know if $OLD_ZDOTDIR gets carried over to “kdevplatform_shell_environment.sh” through “.zshrc”!
> 
> can someone help here?
> 
> 
> Thanks,
> 
> Phil Schaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130728/6dc7b5f4/attachment.html>