Review Request 108915: Change the buildset label to something descriptive

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Feb 11 23:45:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108915/#review27250
-----------------------------------------------------------

Ship it!


I think it makes sense. It's one of those words I've seen forever and are like a #define in my head.

I'd say it's better.

- Aleix Pol Gonzalez


On Feb. 11, 2013, 11:12 p.m., Eli MacKenzie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108915/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 11:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I was unsure of what the "Project Selection" list did, it took some digging in the the documentation to figure it out.
>     
> I wouldn't be opposed to just calling this "Build Set".
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectbuildsetwidget.ui 90e74e1407113755e9616af503f6bc0737995ae6 
> 
> Diff: http://git.reviewboard.kde.org/r/108915/diff/
> 
> 
> Testing
> -------
> 
> It builds and appears in the UI.
> 
> 
> Thanks,
> 
> Eli MacKenzie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130211/3c2b57f9/attachment.html>


More information about the KDevelop-devel mailing list