Review Request 104611: Add a button to close all views from a MultiItem OutputView

Kevin Funk krf at gmx.de
Sun Feb 10 22:54:52 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104611/#review27153
-----------------------------------------------------------


Btw, this makes sense for both HistoryView and Multiple View. Could you make the widget avaialble to both of them?

Also, there actually is a icon for this action, it's called "tab-close-other".
Please update the patch if possible.

- Kevin Funk


On April 16, 2012, 3:09 a.m., Victor Vicente Carvalho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104611/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 3:09 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Implemented a tool button to close all open views besides the last one on a MultiItem OutputView. This patch adds a new button (I wanted it to be on a right click, but the QPushButton doesn't has the event for it and I didn't wanted to implement a custom one). I didn't provided an icon so it's using the same of the close button.
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/outputwidget.h 115909df79ff87a11dbabd7176e4ad6279ed4cdd 
>   plugins/standardoutputview/outputwidget.cpp daf9bd20e02048f8900fd039e41154481ffca8a4 
> 
> Diff: http://git.reviewboard.kde.org/r/104611/diff/
> 
> 
> Testing
> -------
> 
> Ran the debug several times, all windows were closed sucessfully
> 
> 
> Thanks,
> 
> Victor Vicente Carvalho
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130210/87449b10/attachment.html>


More information about the KDevelop-devel mailing list