API of CommandExecutor and its behaviour on non-zero exit codes

[Aleix Pol]

On Mon, Sep 3, 2012 at 1:56 AM, Aleix Pol <aleixpol at kde.org> wrote:
> On Sun, Sep 2, 2012 at 12:39 PM, Andreas Pakulat <apaku at gmx.de> wrote:
>> Hi,
>>
>> On Sun, Sep 2, 2012 at 10:29 AM, Andreas Pakulat <apaku at gmx.de> wrote:
>>> I can add the return-code parameter to completed and adjust all uses
>>> inside kdevelop/kdevplatform along with having the ninja and cmake
>>> code use it.
>>
>> I now went ahead and added the argument to the signal and used it in
>> the builders, so everything should be back to 'normal' (i.e. before my
>> revert) and the CommandExecutor API got some more explanations on what
>> it does and doesn't do.
>>
>> Andreas
>>
>> --
>> KDevelop-devel mailing list
>> KDevelop-devel at kdevelop.org
>> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
> Hi Andreas!
> Thanks for going ahead and taking care of this.
>
> I see you adapted cmake code too, Ninja is fixed as well by using the
> error code, so I think the world is back on track now. :)
>
> Cheers!
> Aleix

And now I see that you fixed ninja too. :P

Thanks!
Aleix