[PATCH] makebuilder: kdesudo install fix

Aleix Pol aleixpol at kde.org
Sat Nov 20 18:47:34 UTC 2010


Can you commit yourself?

On Sat, Nov 20, 2010 at 11:13 AM, Tim Blechmann <tim at klingt.org> wrote:

> when using parallel builds, make install with kdesudo uses a command string
> like:
> kdesudo -t -c make -j4 install
>
> this fails, since -j4 is interpreted as argument to kdesudo, but not to
> make. this patch changes the kdesudo command string to
>
> kdesudo -t -- make -j4 install
>
> Signed-off-by: Tim Blechmann <tim at klingt.org>
> ---
>  projectbuilders/makebuilder/makejob.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/projectbuilders/makebuilder/makejob.cpp
> b/projectbuilders/makebuilder/makejob.cpp
> index eaf7074..a638cc9 100644
> --- a/projectbuilders/makebuilder/makejob.cpp
> +++ b/projectbuilders/makebuilder/makejob.cpp
> @@ -228,7 +228,7 @@ QStringList MakeJob::computeBuildCommand() const
>         QString suCommandName;
>         if (suCommand == 1) {
>           suCommandName = "kdesudo";
> -          arguments << "-t" << "-c" << cmdline;
> +          arguments << "-t" << "--" << cmdline;
>         } else if (suCommand == 2) {
>           suCommandName = "sudo";
>           arguments << cmdline;
> --
> 1.7.1
>
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101120/41a55079/attachment.html>


More information about the KDevelop-devel mailing list