ProjectModel: should ProjectBaseItem::text() be equal to ::baseName() ?

[Aleix Pol]

On Tue, Dec 14, 2010 at 11:54 PM, Milian Wolff <mail at milianw.de> wrote:

> Hey all,
>
> I wonder whether the ProjectBaseItem api is good the way it is. I esp.
> wonder
> whether it should be allowed to setText().
>
> Personally I think that this is nowhere used and that only setUrl() is used
> (or the CTor arguments for the name).
>
> Furthermore there is already code (esp. in CMakeManager) that expects
> text()
> == baseName().
>
> I've just added a caching baseName() for speedup
> (http://rpi.edu/~doriad/callgrind.tar.bz2) but wonder whether that is not
> maybe overkill. I'd like to remove it again and just reuse text() instead.
>
> Bye
> --
> Milian Wolff
> mail at milianw.de
> http://milianw.de
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
Makes sense to me. A patch with the proposed changes would be nice :)

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101215/92091248/attachment.html>