vcsjob starting to output too early

[Aleix Pol]

On Fri, Aug 20, 2010 at 9:03 AM, Andreas Pakulat <apaku at gmx.de> wrote:

> On 19.08.10 14:00:25, Aleix Pol wrote:
> > On Thu, Aug 19, 2010 at 8:19 AM, Andreas Pakulat <apaku at gmx.de> wrote:
> >
> > > On 19.08.10 03:54:10, Aleix Pol wrote:
> > > > I've been trying to put some information on the VersionControl output
> > > view
> > > > to try to be able to see what is the tool that's showing some output.
> > > >
> > > > The thing is that the output is started in VcsJob constructor so we
> don't
> > > > have any chance to put a title into it or an object name or anything
> so
> > > we
> > > > don't have any chance to differentiate. I've locally moved that to
> depend
> > > on
> > > > the VcsJob::start (the developer who implements the support will have
> to
> > > > care about triggering it to show).
> > > >
> > > > I'm just sending this e-mail to know if other developers agree that
> it's
> > > the
> > > > best solution. Another solution would be to delay the start so that
> we
> > > can
> > > > put a title on the constructor but I think waiting until start makes
> it
> > > > easier to provide a meaningful title.
> > >
> > > Can you elaborate with a patch? I can't follow your explanations (maybe
> > > its just too early) :(
> >
> > Sure, maybe mine was too late :P
> >
> > Hope that helps!
>
> Thanks, see my other mail regarding the vcsjob-changes. But I don't
> understand the new action the patch adds. Whats the purpose of that?
>
> Andreas
>
> --
> Beware of low-flying butterflies.
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>

Ah nono, it was just a way to get the information to the view without
changing everything. We definitely want to put it into a widget, I just used
that because I didn't know where to and was in a hurry to get my things
fixed and without that I got tons of weird behaviour (like empty views that
I didn't know where did they come from).

That's why I didn't send a patch the first time.

Can you propose a way to fix that problem?

Thanks,
Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20100820/e1447013/attachment.html>