Review Request: Fixes for Core::initialize(NoGui), added LoadNoPlugins flag for testing plugins

[Fabian Wiesel]

> On 2009-03-15 11:19:10, Andreas Pakulat wrote:
> > The NoUi flag is actually there so that no mainwindow is created. The uicontroller should still be instantiaged. So that part of the patch is wrong.
> > 
> > Regarding the loading of plugins, loadPluginInternal checks wether a plugin is a ui-plugin or not and refuses loading it. I've put two fixes into plugincontroller that make sure that if for a given plugin X any of its dependencies cannot be loaded then X is also not loaded.

I thought KXMLGuiClient::setXMLFile crashing on me was due to a lack of GUI (or more correctly, the lacking check for it).  I will have to investigate this further.
I think the remaining three small changes still apply, however.


- Fabian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/331/#review484
-----------------------------------------------------------


On 2009-03-15 12:47:21, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/331/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 12:47:21)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The UIController may not be created, since there is the Core::Setup::NoGUI-flag for testing purposes.
> The documentation controller didn't expect this and crashes. This should be fixed with the patch attached.
> 
> Also, when testing a plugin, other plugins may rely on the existance of UIController, too.
> To avoid complications, I introduced the LoadNoPlugins flag, which disables
> the automated loading of plugins by not calling PluginController::initialize().
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/shell/documentcontroller.cpp 939793 
>   /trunk/KDE/kdevplatform/shell/uicontroller.cpp 939793 
> 
> Diff: http://reviewboard.kde.org/r/331/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>